Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KEP-3695: Update podResourceV1 API #4913

Merged
merged 1 commit into from
Oct 10, 2024
Merged

KEP-3695: Update podResourceV1 API #4913

merged 1 commit into from
Oct 10, 2024

Conversation

ArangoGutierrez
Copy link
Contributor

  • One-line PR description: Update KEP 3695 to reflect current implementation

@ArangoGutierrez
KEP-3695: Update podResourceV1 API
683affc 
Signed-off-by: Carlos Eduardo Arango Gutierrez <eduardoa@nvidia.com>
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Oct 9, 2024
@k8s-ci-robot k8s-ci-robot added kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory sig/node Categorizes an issue or PR as relevant to SIG Node. labels Oct 9, 2024
@ArangoGutierrez
Copy link
Contributor Author

/cc @klueska @SergeyKanzhelev

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Oct 9, 2024
@ArangoGutierrez ArangoGutierrez mentioned this pull request Oct 9, 2024
Open
8 tasks
@ArangoGutierrez
Copy link
Contributor Author

/cc @aojea

@k8s-ci-robot k8s-ci-robot requested a review from aojea October 9, 2024 10:41
@aojea
Copy link
Member

aojea commented Oct 9, 2024

/lgtm

perfect, thank you very much, appreciate the prompt response

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 9, 2024
@klueska
Copy link
Contributor

klueska commented Oct 9, 2024

/approve

@mrunalp for final approval

@ArangoGutierrez
Copy link
Contributor Author

/assign @derekwaynecarr

kannon92
kannon92 reviewed Oct 9, 2024
View reviewed changes
keps/sig-node/3695-pod-resources-for-dra/README.md
@@ -200,8 +208,8 @@ message CDIDevice {

// GetPodResourcesRequest contains information about the pod
message GetPodResourcesRequest {
string name = 1;
string namespace = 2;
string pod_name = 1;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This would be a major breaking change.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is already merged code, I am just updating the KEP to the existing code base.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/kubernetes/kubernetes/blob/master/staging/src/k8s.io/kubelet/pkg/apis/podresources/v1/api.proto#L113

Just found that out also.

@kannon92
Copy link
Contributor

kannon92 commented Oct 9, 2024

/assign @mrunalp

/lgtm

@kannon92
Copy link
Contributor

kannon92 commented Oct 9, 2024

Just to clarify: this is just cleanup and not a implementation for this feature in 1.32?

Or do we want some development time/reviewers for this feature for 1.32?

@klueska
Copy link
Contributor

klueska commented Oct 9, 2024

No updates expected for this release in terms of code -- this was just a "cleanup" effort to bring the KEP in line with the current code and remove all references in the text saying that these extensions are intended for networking plugins.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ArangoGutierrez, klueska, mrunalp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 10, 2024
@k8s-ci-robot k8s-ci-robot merged commit 4748330 into kubernetes:master Oct 10, 2024
4 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.32 milestone Oct 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kannon92 kannon92 kannon92 left review comments

@mrunalp mrunalp mrunalp approved these changes

@dchen1107 dchen1107 Awaiting requested review from dchen1107

@klueska klueska Awaiting requested review from klueska

@SergeyKanzhelev SergeyKanzhelev Awaiting requested review from SergeyKanzhelev

@aojea aojea Awaiting requested review from aojea

Assignees

@mrunalp mrunalp

@kannon92 kannon92

@derekwaynecarr derekwaynecarr

@aojea aojea

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/node Categorizes an issue or PR as relevant to SIG Node. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.32
Development

Successfully merging this pull request may close these issues.
7 participants
@ArangoGutierrez @aojea @klueska @kannon92 @k8s-ci-robot @mrunalp @derekwaynecarr